Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable notification emails #8911

Merged
merged 20 commits into from
Apr 27, 2023
Merged

Disable notification emails #8911

merged 20 commits into from
Apr 27, 2023

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 25, 2023 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Apr 25, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

dschmidt
dschmidt reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's quite a bit code duplication for the value saving, could you reduce that?

I assume something like

  const updateDisableEmailNotifications = async (option) => {
    await saveValue({
      identifier: 'disable email notifications',
      value: option,
      errorMessage: $gettext('Unable to save notifications email setting…')
    })
    disableEmailNotificationsValue.value = option
  }

should be all we need for a specific value.

packages/web-runtime/src/pages/account.vue Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear marked this pull request as ready for review April 26, 2023 09:56
@AlexAndBear AlexAndBear requested a review from dschmidt April 26, 2023 09:56
@AlexAndBear AlexAndBear requested review from kulmann and lookacat April 26, 2023 13:32
@AlexAndBear
Copy link
Contributor Author

AlexAndBear commented Apr 26, 2023 •
edited
Loading

TBD:

  • Add unit tests

@ownclouders
Copy link
Contributor

ownclouders commented Apr 26, 2023 •
edited
Loading

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35217/68/1
💥 The oCISUploadMove tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

ownclouders commented Apr 26, 2023 •
edited
Loading

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35217/70/1
💥 The oC10IntegrationApp1 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35211/66/1
💥 The oCISSharingPublic2 tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oCIS https://drone.owncloud.com/owncloud/web/35211/68/1
💥 The oCISUploadMove tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for acceptance oC10 https://drone.owncloud.com/owncloud/web/35211/71/1
💥 The oC10IntegrationApp2 tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear requested a review from kulmann April 27, 2023 08:42
@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

81.9% 81.9% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 💪

@kulmann kulmann merged commit 683b0af into master Apr 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the issues/8904 branch April 27, 2023 13:27
@JammingBen JammingBen mentioned this pull request May 3, 2023
Merged
5 tasks
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@lookacat lookacat Awaiting requested review from lookacat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web] Prevent users being email-spammed by notifications
4 participants
@AlexAndBear @ownclouders @dschmidt @kulmann